Skip to content

feat: update Gemini and Vertex AI models from preview to GA version (#5444) #5446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: update Gemini and Vertex AI models from preview to GA version (#5444) #5446

wants to merge 1 commit into from
+40 −111

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jul 7, 2025 •
edited by ellipsis-dev bot
Loading

Description

Fixes #5444

This PR updates the Gemini and Vertex AI model naming conventions from outdated preview versions to the GA (Generally Available) version, as requested in issue #5444. Google has replaced the preview versions with the GA version according to their documentation.

Changes Made

Model Definition Updates

  • Removed outdated preview models from type definitions:
    • gemini-2.5-pro-preview-03-25
    • gemini-2.5-pro-preview-05-06
    • gemini-2.5-pro-preview-06-05
  • Updated to GA model: gemini-2.5-pro across all providers
  • Updated VSCode LLM provider to use the GA model instead of preview
  • Updated OpenRouter provider to remove preview model from reasoning budget models

Backward Compatibility Implementation

  • Added legacy model detection in Gemini provider with isLegacyPreviewModel() method
  • Implemented automatic mapping from preview models to GA version
  • Extended Vertex provider to inherit the same backward compatibility logic
  • Added OpenRouter preview model mapping for google/gemini-2.5-pro-preview

Test Updates

  • Fixed OpenRouter test expectations to reflect removal of supportsReasoningBudget property
  • Ensured all provider tests pass with the new model configurations

Testing

  • All existing tests pass
  • Added backward compatibility logic for existing users
  • Manual testing completed:
    • Gemini provider correctly maps legacy models to GA version
    • Vertex provider inherits the same mapping logic
    • OpenRouter provider handles legacy preview model names
    • No breaking changes for existing configurations

Verification of Acceptance Criteria

  • Remove outdated preview models: All preview model definitions removed from type files
  • Update to GA version: gemini-2.5-pro is now the current model across all providers
  • Maintain backward compatibility: Users with existing preview model selections will automatically get mapped to the GA version
  • Update related integrations: VSCode LLM and OpenRouter providers updated accordingly

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic (backward compatibility mapping)
  • No breaking changes - existing users will seamlessly transition
  • All tests passing
  • Linting checks pass
  • TypeScript compilation successful

Impact

This change ensures that:

  1. Users get the most current and supported model from Google
  2. Existing configurations continue to work without manual intervention
  3. Future model updates follow Google's official naming conventions
  4. No service disruption for current users with preview model selections

Important

Update Gemini and Vertex AI models from preview to GA version, ensuring backward compatibility and updating tests.

  • Model Definition Updates:
    • Removed preview models gemini-2.5-pro-preview-03-25, gemini-2.5-pro-preview-05-06, gemini-2.5-pro-preview-06-05 from gemini.ts and vertex.ts.
    • Updated to GA model gemini-2.5-pro in gemini.ts, vertex.ts, and vscode-llm.ts.
    • Updated openrouter.ts to remove preview model from reasoning budget models.
  • Backward Compatibility:
    • Added isLegacyPreviewModel() in gemini.ts and openrouter.ts for legacy model detection.
    • Implemented automatic mapping from preview models to GA version in gemini.ts, vertex.ts, and openrouter.ts.
  • Test Updates:
    • Fixed test expectations in openrouter.spec.ts to reflect removal of supportsReasoningBudget property.
    • Ensured all provider tests pass with new model configurations.

This description was created by Ellipsis for 36572f2. You can customize this summary. It will automatically update as commits are pushed.

@roomote
feat: update Gemini and Vertex AI models from preview to GA version (#…
36572f2 
…5444)

- Remove outdated preview models (gemini-2.5-pro-preview-*) from type definitions
- Update to GA model (gemini-2.5-pro) across all providers
- Implement backward compatibility for existing users with preview models
- Update OpenRouter integration to remove preview model references
- Fix related tests to reflect model changes

Fixes #5444
@roomote roomote requested review from cte, jr and mrubens as code owners July 7, 2025 13:48
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 7, 2025
@roomote roomote mentioned this pull request Jul 7, 2025
Closed
4 tasks
@dosubot dosubot bot added the enhancement New feature or request label Jul 7, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 7, 2025

✅ No security or compliance issues detected. Reviewed everything up to 36572f2.

Security Overview
  • 🔎 Scanned files: 8 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► gemini.ts
    Add backward compatibility for legacy preview models
► openrouter.ts
    Update model handling and remove preview references
► vertex.ts
    Implement backward compatibility for legacy models
Refactor ► gemini.ts
    Remove outdated preview model definitions
► openrouter.ts
    Update model references and reasoning logic
► vertex.ts
    Remove preview model configurations
► vscode-llm.ts
    Update model version and name

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 7, 2025
@HahaBill
Copy link
Contributor

HahaBill commented Jul 7, 2025

Wow, this is pretty cool!!

But how does this work? Should we just review this PR and modify its branch? Or is it just used for estimation and we should make our own PR?

@daniel-lxs
Copy link
Member

daniel-lxs commented Jul 9, 2025

@HahaBill You can basically ignore these for now, if you plan to open your own PR please feel free to do so

@HahaBill
Copy link
Contributor

HahaBill commented Jul 9, 2025

@HahaBill You can basically ignore these for now, if you plan to open your own PR please feel free to do so

Alright, that makes sense. I am planning to working on this soon after we resolve the other PR.

@daniel-lxs daniel-lxs moved this from Triage to renovate BOT in Roo Code Roadmap Jul 15, 2025
@daniel-lxs
Copy link
Member

daniel-lxs commented Jul 18, 2025

Automatically closed: PR created by @roomote-agent before 2025-07-16

@daniel-lxs daniel-lxs closed this Jul 18, 2025
@github-project-automation github-project-automation bot moved this from Roomote/renovate BOT to Done in Roo Code Roadmap Jul 18, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 18, 2025
@roomote
Copy link
Contributor

roomote bot commented Jul 18, 2025

I've seen the automatic closure of this PR. I'll create a new implementation to address issue #5444 - updating Gemini and Vertex AI models from preview to GA version. The work will include updating model definitions, implementing backward compatibility, and ensuring all tests pass.

@roomote
Copy link
Contributor

roomote bot commented Jul 18, 2025

Implementation Complete!

I've successfully created a new implementation to address issue #5444.

New Pull Request: #5907

Changes Implemented:

  • Removed outdated preview models (gemini-2.5-pro-preview-03-25, gemini-2.5-pro-preview-05-06, gemini-2.5-pro-preview-06-05) from gemini.ts and vertex.ts
  • Added backward compatibility logic in Gemini and Vertex providers to automatically map legacy preview models to gemini-2.5-pro GA version
  • Updated OpenRouter provider to handle legacy preview model mapping
  • Updated OpenRouter tests to reflect the changes

Impact:

  • No breaking changes: Existing users with preview model selections will automatically get the GA version
  • Future-proof: Follows Google's official GA naming conventions
  • Seamless transition: No manual intervention required for existing configurations

The new PR replaces the automatically closed PR #5446 and provides a complete solution for updating Gemini and Vertex AI models to the GA version while maintaining full backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updating Gemini and Vertex AI model's naming convention for gemini-2.5-pro-preview-{dates} to gemini-2.5-pro

5 participants

@roomote @HahaBill @daniel-lxs @hannesrudolph